ScratchAddons icon indicating copy to clipboard operation
ScratchAddons copied to clipboard

Published 20 hours ago • verified publisher icon ScratchAddons

Twelve hour time

Open webdev03 opened this issue 2 years ago • 10 comments

Resolves #4021

Changes

Adds options to forum-time-zones, mainly twelve hour time, but there's also a new relative date option.

Reason for changes

Some people don't like 24 hour time.

Tests

Successful test through Firefox Developer Edition 99 image

webdev03 avatar Mar 11 '22 07:03 webdev03

Yes, @webdev03, it would be better to not have me in the credits for just giving the idea.

jdev082 avatar Mar 11 '22 15:03 jdev082

I'd put this in forum-time-zones tbh

Agreed, but I think forum-time-zones is a bit confusing, maybe renaming the entire addon to something like Customizable Forum Timestamps or something similar is better...

Chiroyce1 avatar Mar 11 '22 16:03 Chiroyce1

I'm converthing this to the forum time zones addon. But I have some questions:

  1. There doesn't seem to be any mention of ScratchDB even though it requests from ScratchDB.
  2. Would I add the credits from twelve-hour-time or just remove them entirely, because nobody added credits for that addon?
  3. Should the relative date option still exist?

webdev03 avatar Mar 11 '22 19:03 webdev03

  1. There doesn't seem to be any mention of ScratchDB even though it requests from ScratchDB.

there should be

  1. Would I add the credits from twelve-hour-time or just remove them entirely, because nobody added credits for that addon?

yes

  1. Should the relative date option still exist?

yes

cobaltt7 avatar Mar 11 '22 20:03 cobaltt7

  1. There doesn't seem to be any mention of ScratchDB even though it requests from ScratchDB.

there should be

  1. Would I add the credits from twelve-hour-time or just remove them entirely, because nobody added credits for that addon?

yes

  1. Should the relative date option still exist?

yes

OK!

webdev03 avatar Mar 11 '22 20:03 webdev03

It should be in forum-time-zones now

webdev03 avatar Mar 13 '22 23:03 webdev03

So the relative date option won't run unless either one is on. So should I make another JS file to handle that if both of those options are off? But a better solution I think might just be to remove the setting since it wasn't there originally.

webdev03 avatar Mar 18 '22 06:03 webdev03

Is this just waiting on reviews?

GrahamSH-LLK avatar May 02 '23 01:05 GrahamSH-LLK

Is this just waiting on reviews?

Maybe, but I think that there should be some changes to the variable names. It has been a long time since I made this PR. Also it looks like there is a conflict in the code that can't be fixed online.

webdev03 avatar May 02 '23 04:05 webdev03

Ping! There has been no activity for 7 days.

scratchaddons-bot[bot] avatar Dec 08 '23 00:12 scratchaddons-bot[bot]