ScratchAddons icon indicating copy to clipboard operation
ScratchAddons copied to clipboard
verified publisher icon ScratchAddons

Scratch messaging only shows the project title on unshared projects

Open Samq64 opened this issue 4 years ago • 7 comments

Description

If someone comments on a project and then I unshare it, Scratch messaging just shows the project title without the comment.

Reproduction steps

  1. Comment on a project made by your alt. (if you have a second account and a project you don't mind unsharing)
  2. Log into your alt and unshare the project.
  3. Open Scratch messaging.

Expected behaviour

The comment should either appear in the Scratch messaging tab or not appear at all.

Actual behaviour

Only the project title appears.

Screenshots

image

Environment

  • Browser: Firefox 95
  • Scratch Addons version: 1,22,1
  • Operating system: Windows 11

Samq64 avatar Dec 12 '21 13:12 Samq64

Wontfix - vanilla project page also hides comments in this case.

apple502j avatar Dec 12 '21 14:12 apple502j

Vanilla project page also hides comments in this case.

No, it doesn't. After unsharing the project, I am still able to see the comment through both the project page and messages page.

Samq64 avatar Dec 12 '21 14:12 Samq64

Wontfix - vanilla project page also hides comments in this case.

I think the addon should try to match the messages page and not the project page if the comment fails to load.

mxmou avatar Dec 12 '21 16:12 mxmou

Re-opening, but low priority IMO

apple502j avatar Dec 13 '21 07:12 apple502j

The project page shows comments on your own unshared projects

From: Maximouse @.> Sent: Sunday, December 12, 2021 10:23:52 AM To: ScratchAddons/ScratchAddons @.> Cc: Subscribed @.***> Subject: Re: [ScratchAddons/ScratchAddons] Scratch messaging only shows the peoject title on unshared projects (Issue #3916)

Wontfix - vanilla project page also hides comments in this case.

I think the addon should try to match the messages page and not the project page if the comment fails to load.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ScratchAddons/ScratchAddons/issues/3916#issuecomment-991927425, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOT5DEQJALOYP54P5UHVLN3UQTEBRANCNFSM5J4H2BGQ.

cobaltt7 avatar Dec 13 '21 12:12 cobaltt7

"peoject" also Screenshot 2021-12-13 183103 note that project was unshared

Dhuls-Scratch avatar Dec 14 '21 00:12 Dhuls-Scratch

~~This only happens with my own projects. Replies to comments on someone else's project that gets unshared don't show up in Scratch messaging at all. (It does show up in the messages page though.)~~

Never mind.

Samq64 avatar Dec 14 '21 15:12 Samq64