ScratchAddons icon indicating copy to clipboard operation
ScratchAddons copied to clipboard

Published 20 hours ago • verified publisher icon ScratchAddons

Live comments

Open FunctionalMetatable opened this issue 3 years ago • 16 comments

Resolves #2215 Supersedes #3041

Changes

On project and studio pages, new comments now load automatically (using redux)

Reason for changes

Make it more like github

Tests

Tested locally

cc @CubeyTheCube

FunctionalMetatable avatar Jul 18 '21 21:07 FunctionalMetatable

@FunctionalMetatable What happens in edge cases? Such as writing a reply to a comment chain that later got deleted.

WorldLanguages avatar Jul 18 '21 22:07 WorldLanguages

What happens in edge cases? Such as writing a reply to a comment chain that later got deleted.

Same as the Cubey's PR:

This doesn't remove deleted comments, because that might generate confusion

Also, requests will become very spammy. Scratch should handle comment deletion as well

FunctionalMetatable avatar Jul 19 '21 05:07 FunctionalMetatable

Let me test this locally.

LankyBox01 avatar Jul 20 '21 20:07 LankyBox01

Bruh, i tried turning this on and going to the TFH studio, and all of the comments start refreshing, but... backwards. The new comments will start dissapearing, and after a few minutes, you will literally see comments from a year ago.

LankyBox01 avatar Jul 20 '21 20:07 LankyBox01

Bruh, i tried turning this on and going to the TFH studio, and all of the comments start refreshing, but... backwards. The new comments will start dissapearing, and after a few minutes, you will literally see comments from a year ago.

hmm(fixed)

FunctionalMetatable avatar Jul 20 '21 20:07 FunctionalMetatable

This is cool but needs to be handled with care, so we might work on this for v1.19.0. Some changes I'd make:

  • Do not request comment data that often - maybe once every 10 seconds
  • Require user to explicitly enable this every time they load the comment page, through a switch
  • Only request comment data if tab is focused and cursor moved / some key was pressed in the last 10 minutes.

I also need to take a deeper look on how the addon works exactly and how it behaves when you load a single comment chain, as well as when you have loaded many pages of comments.

WorldLanguages avatar Jul 28 '21 20:07 WorldLanguages

Backlog, sorry. I'll probably get into this when I have the time, and I'm still not 100% sure whether this is a good idea.

WorldLanguages avatar Oct 06 '21 22:10 WorldLanguages

Honestly, it's probably more useful if we provide some official type of online/offline statuses. That's been the main barrier to "chatting" on Scratch for a while.

WorldLanguages avatar Oct 06 '21 22:10 WorldLanguages

if im correct, st wont like it

Endermaster3690 avatar Oct 07 '21 17:10 Endermaster3690

if im correct, st wont like it

st doesn't even like scratch addons

retronbv avatar Oct 07 '21 19:10 retronbv

if im correct, st wont like it

st doesn't even like scratch addons

Using a browser extension is different from spamming their API.

CubeyTheCube avatar Oct 07 '21 19:10 CubeyTheCube

if im correct, st wont like it

Live comments or online statuses?

WorldLanguages avatar Oct 07 '21 22:10 WorldLanguages

the manifest workflow is erroring, you should have projectPage instead of projects

GrahamSH-LLK avatar Oct 29 '21 14:10 GrahamSH-LLK

any updates? this has been there for toooo long

Weredime avatar Apr 26 '22 19:04 Weredime

What's the status of the requests I made on my review on https://github.com/ScratchAddons/ScratchAddons/pull/3064#issuecomment-888605040 ?

WorldLanguages avatar Jul 21 '22 02:07 WorldLanguages

What's the status of the requests I made on my review on #3064 (comment) ?

TODO

Weredime avatar Jul 21 '22 06:07 Weredime

Is this still under development?

GrahamSH-LLK avatar Dec 22 '22 13:12 GrahamSH-LLK

Closing because #6171 has popped up, and I don't have the time to maintain this anymore (i am @FunctionalMetatable)

Weredime avatar Jul 09 '23 18:07 Weredime