Scotty

Results 61 comments of Scotty

> If the provider returns undefined, we create an empty buffer at that point and return it. So, I think we need to revert your change in `getContractStorage`. ~~Where does...

The tests I've written do not test the "blockTag" parameter for `getBalance`, `getStorageAt`, and `getTransactionCount`, and I'm having wondering what you think the best approach to that might be?

> A fruitful set of tests would be to run a couple of transactions and then verify that the post account balances match up. I can probably help devise a...

> We need to add a private vm property to the provider and instantiate it using the ethersStateManager property. Is there a good way to instantiate a VM in a...

> If I'm thinking about things correctly, since the private vm will run the transactions using the ethersStateManager, the state updated applied by running the transaction should magically be updated...

One of the `trie/test/proof.spec.ts` failed when everything else passed. This tested a valid proof with an invalid key, which should return null. The failure may have been a `vitest` issue,...

## Benchmarks: ### master: ``` ------- Benchmarking ------- Benchmarking 1k-3-32-ran x 3 ops/sec @ 296ms/op 1k-5-32-ran x 3 ops/sec @ 292ms/op 1k-9-32-ran x 3 ops/sec @ 287ms/op 1k-1k-32-ran x 3...

| bench | master | PR | compare | |---|---|---|---| |1k-3-32-ran |x 3 ops/sec @ 296ms/op |x 2 ops/sec @ 356ms/op | +60 ms/op | |1k-5-32-ran |x 3 ops/sec @...

@holgerd77 I pared this down to as few lines of code as I could manage. hope this is closer to what you were looking for. :pray: the benchmark performance is...

Took a stab at this following the model of the Ultralight provider. Biggest question has to do with `getAccount` - and what the equivalent `ethers` call is.