Scott P. Jones
Scott P. Jones
ShortStrings don't store a terminating null anyway. I've frequently needed strings that were just "\0", or had a '\0' at the end. Having to deal with a single byte "lost"...
This needs to have `@static if VERSION >= ...` ... `end` around the tests for parsing arguments at the end of a string. That causes the tests to fail on...
I think that deprecating ShortStrings should wait, InlineString doesn't completely replace SSs (it doesn't have a string macro to make using them more convenient, for example), and it really needs...
I just did some simple tests of `==`, comparing different sized InlineStrings to each other, to Strings, and SubStrings. In many places, it looks like operations fall back to ones...
I'll start reviewing this this weekend. Great to see more being done to handle strings in a good way! Did you look at the discussions about making the encodings use...
This definitely looks like a good start! I hope you don't mind all the comments!
I was just thinking also, a lot of the classification that I'd like to see can be done programmatically, for example to check if an 8-bit character set is ASCII...
Ah, that's great, it also has the information to decide whether it is single, double, or multi code unit, I see.
The new encodinginfo stuff looks much better, yes. It will be nice if we can come up with a way to automatically generate the tables, from either iconv or ICU....
Those generators from iconv-lite look nice (even if they are in JS instead of Julia! ;-) ), I see he does what I'd been talking about, and checks to see...