Scott Dugas

It would be good to have some tests of Lucene where there are multiple different stores being used at the same time to make sure they don't interact in weird...

Batch GRV Rate Limit Exceeded is not always thrown

2

The tests noted in https://github.com/FoundationDB/fdb-record-layer/issues/2813 will occasionally run forever due to this code: https://github.com/FoundationDB/fdb-record-layer/blob/200ac05041a1af712f621a27b4c5c37f9eab001c/fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/provider/foundationdb/storestate/FDBRecordStoreStateCacheEntry.java#L97-L100 Where it is combining two futures. The first one: `recordStore.loadRecordStoreStateAsync` is doing a regular read. The...

Some followup from PR #2954

2

- [Add MoreAsyncUtil.ALREADY_CANCELLED](https://github.com/FoundationDB/fdb-record-layer/commit/aaf4ebd4796ff08a6795b9fc87f749a2e1fc49cd) MapPipelineCursor and FlatMapPipelinedCursor had a version of this, so reducing duplication. - [Test concurrent closing with a non-singleton inner cursor](https://github.com/FoundationDB/fdb-record-layer/commit/d489748fcf00bfcf7352620f0a372a1688d89437)

Sometimes the test times out: ``` 2024-09-06T07:50:36.194640Z FDBLuceneQueryTest > threadedLuceneScanDoesntBreakPlannerAndSearch-PoolThreadCount=1 STARTED 2024-09-06T07:55:41.248346Z FDBLuceneQueryTest > threadedLuceneScanDoesntBreakPlannerAndSearch-PoolThreadCount=1 FAILURE (305,006ms) FDBLuceneQueryTest > threadedLuceneScanDoesntBreakPlannerAndSearch(Integer) > com.apple.foundationdb.record.lucene.FDBLuceneQueryTest.threadedLuceneScanDoesntBreakPlannerAndSearch(Integer)[1] FAILED java.util.concurrent.TimeoutException: threadedLuceneScanDoesntBreakPlannerAndSearch(java.lang.Integer) timed out after 5 minutes...

For example: ``` LuceneIndexMaintenanceTest > concurrentStoreTest(boolean, boolean, boolean, int, long) > com.apple.foundationdb.record.lucene.LuceneIndexMaintenanceTest.concurrentStoreTest(boolean, boolean, boolean, int, long)[2] FAILED java.util.concurrent.CompletionException: java.lang.RuntimeException: Failed merge at iteration 16 at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314) at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1702)...

LuceneOptimizedStoredFieldsFormatTest > testNumericField cannot find stored fields sometimes

2

This happens sometimes (with the same seed): ``` LuceneOptimizedStoredFieldsFormatTest > testNumericField FAILED com.apple.foundationdb.record.RecordCoreStorageException: Could not find stored fields at __randomizedtesting.SeedInfo.seed([C185081D42F0F43C:91AB1306856D114E]:0) at app//com.apple.foundationdb.record.lucene.directory.FDBDirectory.readStoredFields(FDBDirectory.java:539) at app//com.apple.foundationdb.record.lucene.codec.LuceneOptimizedStoredFieldsReader.visitDocument(LuceneOptimizedStoredFieldsReader.java:76) at app//org.apache.lucene.index.CodecReader.document(CodecReader.java:84) at app//org.apache.lucene.index.IndexReader.document(IndexReader.java:352) at app//org.apache.lucene.index.BaseStoredFieldsFormatTestCase.testNumericField(BaseStoredFieldsFormatTestCase.java:297)...

LuceneIndexMaintenanceTest sometimes take many minutes

1

I've seen test runs where it takes many minutes. Often on `manyDocument` or `manyDocumentSlow` or `concurrentStoreTest`