Scott B

Results 34 comments of Scott B

> I don't know why in the docker image it fails and on my native machine it works correctly. We need further investigation. Cool, thanks! If I have time, I'll...

> It seems to not invoke your function because of [an if statement ](https://github.com/ScottBailey/CPM.cmake/blob/779328486b030ac59b083032c5604eda3e143074/cmake/CPM.cmake#L761) Good catch, I think I may have fixed it in 311cd3f.

The PATCHES command is currently a gaping hole in CMake's `fetch_content` functionality. This PR addresses that in the simplest way possible. @Gerodote Please feel free to review and comment on...

CPM already has the patch command, is this to add more convenience? If this is to add convenience, CPM could do `find_package(Patch)` for the `patch` command and simply apply it...

`PATCH_COMMAND` is sent as part of `CPM_ARGS_UNPARSED_ARGUMENTS` to [`CMake propper`](https://cmake.org/cmake/help/latest/module/ExternalProject.html#patch-step-options) without modification. It would be GREAT if `cmake -E patch` existed. But it doesn't. Yet.

I think your syntax for patch is wrong. I appreciate that you want to simply apply all the patches, but why dont you take a step back and do this...

Here is the [cmake issue](https://gitlab.kitware.com/cmake/cmake/-/issues/16854) for adding `cmake -E patch`. This CPM issue could be done by adding a `PATCH` option that took a list of files and appended `"${PatchEXECUTABLE}"...

Got a simple repo? I *know* the magic_enum patch sample I have works. What OS are you on?