umbra-protocol icon indicating copy to clipboard operation
umbra-protocol copied to clipboard
verified publisher icon ScopeLift

refactor: periphery contracts refactor/cleanup

Open mds1 opened this issue 3 years ago • 2 comments

  • Configure and run forge fmt
  • Check formatting in CI
  • Use named imports
  • Remove extra balanceOf check in UniswapWithdrawHook.tokensWithdrawn()

mds1 avatar Oct 03 '22 21:10 mds1

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
Latest commit aea19d6c24fbd47f9dd0d449412ded80a2443776
Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/635848ba1554c10009009d0b
Deploy Preview https://deploy-preview-397--jolly-shaw-20fe62.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 03 '22 21:10 netlify[bot]

@apbendi re forge fmt changes, are you on the latest forge version? Given the CI passes and it uses the most recent version I suspect yours may be outdated (unless forge fmt changed since CI was ran)

mds1 avatar Oct 12 '22 18:10 mds1