Versions icon indicating copy to clipboard operation
Versions copied to clipboard

mpv-v3-git: Add Version 20230430

Open b4imetu opened this issue 1 year ago • 5 comments

Closes https://github.com/ScoopInstaller/Extras/pull/11123

Relates to https://github.com/ScoopInstaller/Extras/pull/11123

& Removed 32-bit architecture

b4imetu avatar May 01 '23 16:05 b4imetu

All changes look good.

Wait for review from human collaborators.

mpv-v3-git

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar May 01 '23 16:05 github-actions[bot]

All changes look good.

Wait for review from human collaborators.

mpv-v3-git

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Jun 08 '23 10:06 github-actions[bot]

https://github.com/ScoopInstaller/Extras/pull/11123

What do you think of this pr? @brian6932 @HUMORCE

b4imetu avatar Jun 08 '23 10:06 b4imetu

It's fine. I'm leaning towards the side that it should just be apart of mpv-git, as opposed to a separate manifest tho, how many people even have > 10 year old CPUs? CPUs with these instruction sets are very common nowadays.

If anything, I would prefer that v3 would be the default experience, and that if a manifest was to be added to the versions bucket, it should be the legacy one currently in use. Imo, compilation with modern instruction sets should be the default binary experience.

brian6932 avatar Jun 08 '23 22:06 brian6932

@brian6932 I agree with what you said. However, the developer of mpv has yet to release a stable version of mpv-v3. Given that the stable version still defaults to the old mpv, I think they may want to reach a wider user base (and there is little difference between the two in terms of usage). Of course, since mpv-git users tend to enjoy trying new things, I also agree with making v3 the default option for mpv-git.

In order to use mpv-v3 on scoop, I hope that the maintainers of scoop will include it as soon as possible. Any PR would be greatly appreciated. Thank you! @HUMORCE

b4imetu avatar Jun 09 '23 09:06 b4imetu