Scoop icon indicating copy to clipboard operation
Scoop copied to clipboard

[bug] `scoop` called externally from inside the code

Open hagaigold opened this issue 1 year ago • 0 comments

Bug Report

Current Behavior

scoop been called externally from inside the code:

https://github.com/ScoopInstaller/Scoop/blob/6cdcc75ad84add9deedad81f1c9c16dc43f868c0/libexec/scoop-install.ps1#L55-L61 https://github.com/ScoopInstaller/Scoop/blob/6cdcc75ad84add9deedad81f1c9c16dc43f868c0/libexec/scoop-create.ps1#L61-L63

Expected Behavior

Call should be internally without spawn another process.

Additional context/output

Overall, calling "myself" externally, it is bad practice, unless there is a good reason for doing it.

Possible Solution

call scoop internally.

hagaigold avatar Oct 14 '23 16:10 hagaigold