PHP icon indicating copy to clipboard operation
PHP copied to clipboard

PHP: Add version 8.4

Open JorrinKievit opened this issue 9 months ago • 1 comments

JorrinKievit avatar Feb 26 '25 21:02 JorrinKievit

/verify

niheaven avatar Mar 02 '25 14:03 niheaven

@r15ch13 Can this be merged into the master branch? Thanks

ndsmyter avatar Apr 13 '25 21:04 ndsmyter

Walkthrough

Adds two new Scoop bucket manifests for PHP 8.4.12: a thread-safe default (php8.4.json) and a non-thread-safe variant (php8.4-nts.json). Each defines metadata, architecture-specific URLs and hashes, post-install hook, env var setup, bin entries, persistent config directory, version check, and autoupdate rules.

Changes

Cohort / File(s) Summary of Changes
New PHP 8.4 manifests
bucket/php8.4.json, bucket/php8.4-nts.json
Added manifests for PHP 8.4.12 with metadata (version, homepage, description, license, vcredist suggestion), 32bit/64bit download URLs and sha256 hashes, post_install script call, PHP_INI_SCAN_DIR env var, php.exe and php-cgi.exe bins, conf.d persistence, checkver scraping rules, and autoupdate with versioned URLs and external hash source.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibble on JSON, carrots in tow,
Two fresh manifests ready to go.
Hashes aligned, URLs in line,
Post-install hops—everything fine.
php.exe paths under moonlit hue—
conf.d persists, and updates too.
Thump-thump: 8.4, brand new! 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is empty and does not include any sections from the required template such as a summary of changes, issue references (Closes/Relates), or the confirmation checklist. Please add a detailed description that follows the repository’s template by summarizing the changes, linking to the relevant issue with a “Closes #XXXX” or “Relates to #XXXX” statement, and marking the checklist items to confirm adherence to contribution guidelines.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title cleanly identifies the manifests affected (php8.4 and php8.4-nts) and the action taken (adding version 8.4.12), making it immediately clear what the change entails.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9af3e9084814dd3621b1c9cfa4e1a7c5f04f6ce8 and d9a2e672db08a880a71e50f3ddef9d2444ff36e9.

📒 Files selected for processing (2)
  • bucket/php8.4-nts.json (1 hunks)
  • bucket/php8.4.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • bucket/php8.4-nts.json
  • bucket/php8.4.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Sep 22 '25 09:09 coderabbitai[bot]

/verify

z-Fng avatar Sep 22 '25 10:09 z-Fng

All changes look good.

Wait for review from human collaborators.

php8.4-nts

  • [x] Lint
  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

php8.4

  • [x] Lint
  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

Check the full log for details.

github-actions[bot] avatar Sep 22 '25 10:09 github-actions[bot]