Main icon indicating copy to clipboard operation
Main copied to clipboard

`yt-dlp`: add `js-runtime` to `suggest`

Open candrapersada opened this issue 1 month ago • 14 comments

suggest add deno as dependency yt-dlp

Closes #7359

  • [x] Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • [x] I have read the Contributing Guide

candrapersada avatar Nov 03 '25 18:11 candrapersada

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

yt-dlp

  • [ ] Lint
  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

Check the full log for details.

github-actions[bot] avatar Nov 03 '25 18:11 github-actions[bot]

/verify

Lutra-Fs avatar Nov 07 '25 10:11 Lutra-Fs

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

yt-dlp

  • [ ] Lint
  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

Check the full log for details.

github-actions[bot] avatar Nov 07 '25 10:11 github-actions[bot]

Deno is 64-bit only, 32-bit users have to use nodejs, which is not enabled in yt-dlp by default.

I think it would be better if you could add the above line to notes field.

The easiest way to enable nodejs support is Alpine's approach but I'm not sure how to integrate that into scoop, probably via postinstall script. Otherwise you should notify 32-bit nodejs users that they have to use yt-dlp --js-runtimes node everytime they want to download YouTube videos.

Vinfall avatar Nov 16 '25 07:11 Vinfall

        "32bit": {
            "bin": [
                [
                    "yt-dlp.exe",
                    "yt-dlp",
                    "--no-js-runtimes --js-runtimes node"
                ]

candrapersada avatar Nov 16 '25 09:11 candrapersada

/verify

Lutra-Fs avatar Nov 16 '25 10:11 Lutra-Fs

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

yt-dlp

  • [ ] Lint
  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

Check the full log for details.

github-actions[bot] avatar Nov 16 '25 10:11 github-actions[bot]

/verify

Lutra-Fs avatar Nov 16 '25 10:11 Lutra-Fs

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

yt-dlp

  • [x] Lint
  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

Check the full log for details.

github-actions[bot] avatar Nov 16 '25 10:11 github-actions[bot]

/verify

Lutra-Fs avatar Nov 16 '25 10:11 Lutra-Fs

All changes look good.

Wait for review from human collaborators.

yt-dlp

  • [x] Lint
  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

Check the full log for details.

github-actions[bot] avatar Nov 16 '25 10:11 github-actions[bot]

        "32bit": {
            "bin": [
                [
                    "yt-dlp.exe",
                    "yt-dlp",
                    "--no-js-runtimes --js-runtimes node"
                ]

I think adding a note is sufficient here, since 32-bit users can enable YouTube support by opting in to quickjs or versions/nodejs22. There’s no need for additional changes to update the shim for 32bit user specifically.

Lutra-Fs avatar Nov 16 '25 10:11 Lutra-Fs

I'll submit a manifest PR for quickjs shortly, allowing us to recommend quickjs for 32-bit users as well.

For reference, yt-dlp has the following requirements:

  • Minimum supported Node.js version: 20.0.0
  • Strongly recommended Node.js version: 25+ (for security reasons)

But for 32bit users, they can only install nodejs22 in versions bucket. So quickjs might be a viable option here

Lutra-Fs avatar Nov 16 '25 10:11 Lutra-Fs

but by default it uses deno or none if without enable --js-runtime even though it uses 32-bit

candrapersada avatar Nov 16 '25 10:11 candrapersada