Main icon indicating copy to clipboard operation
Main copied to clipboard

vivid: Add version 0.10.1

Open jack-mil opened this issue 8 months ago • 1 comments

Vivid is dual licensed, so I used the format as specified in the manifest documentation

Closes #6717

  • [x] Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • [x] I have read the Contributing Guide

jack-mil avatar Apr 14 '25 22:04 jack-mil

All changes look good.

Wait for review from human collaborators.

vivid

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Apr 14 '25 22:04 github-actions[bot]

Walkthrough

Adds a new Scoop package manifest bucket/vivid.json for the vivid LS_COLORS generator, defining metadata, notes, suggestions, 32/64-bit architecture entries with download URLs/hashes/extract dirs, bin mapping, checkver, and autoupdate rules.

Changes

Cohort / File(s) Summary of changes
Scoop manifest: vivid
bucket/vivid.json
New manifest introducing version, metadata (description, homepage, license, notes), suggest, 64bit/32bit architecture blocks (url, sha256, extract_dir), bin mapping to vivid.exe, checkver alias, and autoupdate with templated URLs and per-arch extract paths.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant User
    participant Scoop
    participant GitHubReleases as "GitHub Releases"
    participant Downloader
    participant Extractor
    participant InstallDir as "Install Dir"

    User->>Scoop: scoop install vivid
    Scoop->>GitHubReleases: query release (checkver/autoupdate)
    GitHubReleases-->>Scoop: release metadata + asset URLs
    Scoop->>Downloader: download appropriate arch asset (url)
    Downloader->>Extractor: provide archive
    Extractor->>InstallDir: extract to specified extract_dir
    InstallDir->>Scoop: place `vivid.exe` and bin mapping
    Scoop-->>User: install complete
    Note over Scoop,GitHubReleases: autoupdate uses version templates per-arch

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

In a bucket I burrow, bright and keen,
New hues for listings—vivid sheen.
Hashes snug, URLs aligned,
Autoupdates mapped, well-defined.
I tap my paw: bin is set—colors hop in, the brightest yet! 🌈🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description retains the template comments and includes the required checkboxes but does not provide the mandatory general summary of changes, such as adding the vivid package manifest for version 0.10.1, leaving reviewers without clear context for the PR’s purpose. Please add a clear general summary at the top of the pull request description that outlines the addition of the vivid manifest for version 0.10.1 and any other key changes, ensuring that this summary appears outside of HTML comments and all template sections are appropriately completed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly indicates the addition of version 0.10.1 for the vivid manifest and follows the conventional <manifest-name[@version]>: <summary> format while succinctly describing the main change.
Linked Issues Check ✅ Passed The added manifest includes all coding requirements from issue #6717, including homepage, versioned download URLs for both architectures, license information, checkver and autoupdate entries, and a bin path, satisfying the criteria for a standard install of the non-GUI tool.
Out of Scope Changes Check ✅ Passed The PR only adds the vivid manifest file and does not introduce any unrelated changes to other files or configurations, so all modifications are within the scope of the request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Oct 03 '25 19:10 coderabbitai[bot]

/verify

z-Fng avatar Oct 03 '25 19:10 z-Fng

All changes look good.

Wait for review from human collaborators.

vivid

  • [x] Lint
  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

Check the full log for details.

github-actions[bot] avatar Oct 03 '25 19:10 github-actions[bot]

Thanks! @jack-mil @noidilin

z-Fng avatar Oct 03 '25 19:10 z-Fng