Main icon indicating copy to clipboard operation
Main copied to clipboard

Published 20 hours ago • verified publisher icon ScoopInstaller

Nats-Server: Add version 2.9.0

Open Lemorz56 opened this issue 2 years ago • 3 comments

Closes #3953

I would like to hold on with merging the PR until I've gotten a final response from the NATS team. Still like to get feedback and verify it.

Lemorz56 avatar Sep 23 '22 19:09 Lemorz56

/verify

Lemorz56 avatar Sep 23 '22 19:09 Lemorz56

Your changes do not pass checks.

nats-server

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Sep 23 '22 19:09 github-actions[bot]

Couple of more things:

  • Add 32bit variant: https://github.com/nats-io/nats-server/releases/download/v2.9.1/nats-server-v2.9.1-windows-386.zip
  • Add autoupdate hash extraction: https://github.com/nats-io/nats-server/releases/download/v2.9.1/SHA256SUMS

rashil2000 avatar Sep 25 '22 19:09 rashil2000

Couple of more things:

  • Add 32bit variant: https://github.com/nats-io/nats-server/releases/download/v2.9.1/nats-server-v2.9.1-windows-386.zip
  • Add autoupdate hash extraction: https://github.com/nats-io/nats-server/releases/download/v2.9.1/SHA256SUMS

Sorry for taking so long. Added the 32bit exe and the hash for versioning. I'm not sure the regex for the hash works as intended though so I'd love if you could check it out. Seems to work locally though 👍🏼

Lemorz56 avatar Oct 07 '22 20:10 Lemorz56

/verify

rashil2000 avatar Oct 07 '22 20:10 rashil2000

All changes look good.

Wait for review from human collaborators.

nats-server

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

github-actions[bot] avatar Oct 07 '22 20:10 github-actions[bot]

I'm still awaiting an answer from the NATS team.

Lemorz56 avatar Oct 07 '22 20:10 Lemorz56

I'm a committer on NATS team. We approve this PR. One question, how do we ensure that is does not get modified by anyone without approval?

scottf avatar Oct 13 '22 19:10 scottf

Only members of the ScoopInstaller 'maintainers' team can approve/modify changes here.

rashil2000 avatar Oct 14 '22 01:10 rashil2000

Another thing: Scoop just released support for Arm64 architecture. @Lemorz56 could you add that too?

rashil2000 avatar Oct 14 '22 01:10 rashil2000

Added arm64 and bumped version to 2.9.3 @rashil2000

Lemorz56 avatar Oct 18 '22 18:10 Lemorz56

LGTM

scottf avatar Oct 18 '22 22:10 scottf

/verify

rashil2000 avatar Oct 19 '22 21:10 rashil2000

All changes look good.

Wait for review from human collaborators.

nats-server

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Oct 19 '22 21:10 github-actions[bot]