Java icon indicating copy to clipboard operation
Java copied to clipboard

Zulu enhancements

Open ryansuhartanto opened this issue 10 months ago • 5 comments

Should resolves #514.

ryansuhartanto avatar Apr 19 '24 07:04 ryansuhartanto

Your changes do not pass checks.

microsoft21-jdk

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

zulu-jdk

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [ ] Autoupdate
  • [ ] Autoupdate Hash Extraction

zulu-jre

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

zulufx-jdk

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

zulufx-jre

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate
  • [x] Autoupdate Hash Extraction

github-actions[bot] avatar Apr 19 '24 07:04 github-actions[bot]

I'll use this jsonpath to filter the version and product UUIDs

$..['distro_version','package_uuid']

And then I use regex to match it (example: https://regex101.com/r/bYBxsK/1)

\[\s*\[\s*(?<major>\d+),\s*(?<minor>\d+),\s*(?<patch>\d+),\s*\d\s*\],\s*"(?<amd64>[\w-]+)"(?:,\s*\[\s*(?:\d+,?\s*)+\],\s*"(?<i686>[\w-]+)")\s*\]

ryansuhartanto avatar Apr 23 '24 11:04 ryansuhartanto

I think I found a bug when doing json_path.

$ json_path '[{"availability_type":"CA","distro_version":[17,48,15,0],"download_url":"https://cdn.azul.com/zulu/bin/zulu17.48.15-ca-fx-jre17.0.10-win_x64.zip","java_version":[17,0,10],"latest":true,"name":"zulu17.48.15-ca-fx-jre17.0.10-win_x64.zip","openjdk_build_number":7,"package_uuid":"cef00b50-77db-400a-afdd-b9e391e44631","product":"zulu"},{"availability_type":"CA","distro_version":[17,48,15,0],"download_url":"https://cdn.azul.com/zulu/bin/zulu17.48.15-ca-fx-jre17.0.10-win_i686.zip","java_version":[17,0,10],"latest":true,"name":"zulu17.48.15-ca-fx-jre17.0.10-win_i686.zip","openjdk_build_number":7,"package_uuid":"25351721-5e7e-4eef-a0ef-0c3686b38631","product":"zulu"}]' "$..['distro_version','package_uuid']" $null $false $false
[
  17,
  48,
  15,
  0
]\ncef00b50-77db-400a-afdd-b9e391e44631\n[
  17,
  48,
  15,
  0
]\n25351721-5e7e-4eef-a0ef-0c3686b38631

ryansuhartanto avatar Apr 23 '24 11:04 ryansuhartanto

Product UUIDs is discarded using this technique, but this is the best I can do for the current Scoop version by utilizing include_fields.

ryansuhartanto avatar May 13 '24 10:05 ryansuhartanto

@se35710 You have approved most of the recent PR's. What is needed to get this PR merged?

eijckron avatar May 18 '24 07:05 eijckron

@se35710 You have approved most of the recent PR's. What is needed to get this PR merged?

Just a little unsure about the JEP 449 and the removal of x86-32 binaries. Going to merge it now.

se35710 avatar May 22 '24 15:05 se35710