Extras icon indicating copy to clipboard operation
Extras copied to clipboard

uniextract2: prevent warning window pop-up from happening

Open kris3713 opened this issue 3 years ago • 20 comments

Fixes this issue when the user runs the command for the first time: image_7

kris3713 avatar Sep 27 '22 11:09 kris3713

/verify

kris3713 avatar Sep 27 '22 11:09 kris3713

Your changes do not pass checks.

uniextract2

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [ ] Autoupdate

github-actions[bot] avatar Sep 27 '22 11:09 github-actions[bot]

/verify

kris3713 avatar Sep 27 '22 12:09 kris3713

Your changes do not pass checks.

uniextract2

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [ ] Autoupdate

github-actions[bot] avatar Sep 27 '22 12:09 github-actions[bot]

/verify

kris3713 avatar Sep 27 '22 12:09 kris3713

Your changes do not pass checks.

uniextract2

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [ ] Autoupdate

github-actions[bot] avatar Sep 27 '22 12:09 github-actions[bot]

/verify

kris3713 avatar Sep 27 '22 12:09 kris3713

Your changes do not pass checks.

uniextract2

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [ ] Autoupdate

github-actions[bot] avatar Sep 27 '22 12:09 github-actions[bot]

/verify

kris3713 avatar Sep 27 '22 12:09 kris3713

Your changes do not pass checks.

uniextract2

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [ ] Autoupdate

github-actions[bot] avatar Sep 27 '22 12:09 github-actions[bot]

I think the warning is necessary, Warn user before executing malicious files for extraction.

ViCrack avatar Sep 27 '22 12:09 ViCrack

/verify

kris3713 avatar Sep 27 '22 12:09 kris3713

Your changes do not pass checks.

uniextract2

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [ ] Autoupdate

github-actions[bot] avatar Sep 27 '22 12:09 github-actions[bot]

https://github.com/ScoopInstaller/Extras/pull/9344#issuecomment-1259452722

I think the warning is necessary, Warn user before executing malicious files for extraction.

Should I create a .ps1 script that allows users to disable the warning message if they want to?

kris3713 avatar Sep 27 '22 12:09 kris3713

/verify

kris3713 avatar Sep 27 '22 12:09 kris3713

All changes look good.

Wait for review from human collaborators.

uniextract2

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Sep 27 '22 12:09 github-actions[bot]

/verify

kris3713 avatar Sep 27 '22 12:09 kris3713

All changes look good.

Wait for review from human collaborators.

uniextract2

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Sep 27 '22 12:09 github-actions[bot]

Should I create a .ps1 script that allows users to disable the warning message if they want to?

Maybe you can make a issue to their repo(UniExtract2) to fix /silent parameter?

ViCrack avatar Sep 27 '22 13:09 ViCrack

Alright, the disable-warning.ps1 script is made and done. Now anyone can disable the warning pop-up if they want to.

kris3713 avatar Sep 27 '22 13:09 kris3713