Extras
Extras copied to clipboard
ScoopInstaller
windows-terminal: fix context menu error in drive root folder
Could the powershell gallery being down be causing this?
edit: this being the ci failure.
How has this been tested?
Well, here is an example:
While in disk volume C, the %V returns C:\, and the command being "wt.exe" -d "C:\", somehow the backslash is treated as a escape character in this situation, then wt returns error could not access starting directory "C:""
Fortunately C:/ is a valid path for wt
How has this been tested?
Well, here is an example: While in disk volume C, the
%VreturnsC:\, and the command being"wt.exe" -d "C:\", somehow the backslash is treated as a escape character in this situation, then wt returns errorcould not access starting directory "C:""FortunatelyC:/is a valid path for wt
Since we just added a / in this case wouldn't the commandline now expand to C:\/?
How has this been tested?
Well, here is an example: While in disk volume C, the
%VreturnsC:\, and the command being"wt.exe" -d "C:\", somehow the backslash is treated as a escape character in this situation, then wt returns errorcould not access starting directory "C:""FortunatelyC:/is a valid path for wtSince we just added a
/in this case wouldn't the commandline now expand toC:\/?
That's possible... But according to the error report above, I think that may finally be C:/. I guess that by using the variable %V, only path for drive root folder ends with a backslash, which is misprocessed and causes this error. Anyway, both wt.exe -d C:/ and wt.exe -d C:\/ are workable in this case.
And I found "wt.exe" -d "." also works in drive root folder, maybe we should turn to use this?
I think it will be better to see how Windows Terminal installed from the Store does it
Related https://github.com/ScoopInstaller/Versions/pull/557
