Extras icon indicating copy to clipboard operation
Extras copied to clipboard

[Request] SDL2

Open criticic opened this issue 3 years ago • 4 comments

Sort of Master Post related to SDL

Package Request

SDL2 (Base library)

https://www.libsdl.org/download-2.0.php

  • [x] VC (https://github.com/ScoopInstaller/Extras/blob/master/bucket/sdl2.json)
  • [ ] MinGW

SDL_image (image)

https://www.libsdl.org/projects/SDL_image

  • [x] VC (https://github.com/ScoopInstaller/Extras/blob/master/bucket/sdl2-image.json)
  • [ ] MinGW

SDL_ttf (font)

https://github.com/libsdl-org/SDL_ttf

  • [x] VC (https://github.com/ScoopInstaller/Extras/blob/master/bucket/sdl2-ttf.json)
  • [ ] MinGW

SDL_mixer (sound)

https://www.libsdl.org/projects/SDL_mixer/

  • [x] VC (https://github.com/ScoopInstaller/Extras/blob/master/bucket/sdl2-mixer.json)
  • [ ] MinGW

Bug fix

Currently the entire source code is downloaded, but we only need the package config file. So it would make sense to somehow just get the package config(eg. https://raw.githubusercontent.com/libsdl-org/SDL/main/sdl2.pc.in)

Some indication of popularity/repute: [GitHub stars/software reviews etc.] https://www.wikiwand.com/en/List_of_games_using_SDL https://itch.io/games/made-with-sdl

criticic avatar Jan 29 '22 12:01 criticic

Related https://github.com/ScoopInstaller/Extras/pull/4259

rashil2000 avatar Jan 29 '22 14:01 rashil2000

@rashil2000 how exactly should the mingw packages be added? Would making them available to pkg-config suffice? Does it need to be added to its own /bin /lib etc ?

criticic avatar Jan 31 '22 15:01 criticic

Sorry, I have no idea about this software, I won't be able to help :(

(I trust the contributors who are familiar with it when they submit the manifest).

rashil2000 avatar Feb 01 '22 06:02 rashil2000

Would making them available to pkg-config suffice?

In short, yes, exposing to pkg-config is enough. If scoop has since added a standardized way to do this, great. At the time of the originating PR, none existed, so a global environment variable was used which pkg-config will pick up.

Of course, there are other ways the library can be found (e.g. FindSDL2.cmake) but this comes with its own drama ❤️ and is probably best for another repo. :)

Does it need to be added to its own /bin /lib etc ?

Not necessarily, as long as it can be found.

tresf avatar Jul 18 '22 03:07 tresf

For whatever reason, pkg-config does not work even though the envs are set.

rongcuid avatar Jan 02 '23 16:01 rongcuid

For whatever reason, pkg-config does not work even though the envs are set.

As long as pkg-config honors that variable, it should work. My only recommendation is to echo its value just before use and ensure the path separators are valid for your operating system.

tresf avatar Jan 02 '23 19:01 tresf