Extras icon indicating copy to clipboard operation
Extras copied to clipboard

tftpd: Update to version 4.71

Open Trevrosa opened this issue 4 months ago β€’ 10 comments

Updates manifest to latest version of tftpd (4.71).

Uses Github releases instead of Bitbucket as the Bitbucket repository no longer exists.

Also changes the license from EUPL-1.1 to GPL-2.0-only as per the repository's license.md.

Closes #15449

Trevrosa avatar Aug 11 '25 10:08 Trevrosa

/verify

Trevrosa avatar Aug 11 '25 10:08 Trevrosa

Your changes do not pass checks.

tftpd

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Aug 11 '25 10:08 github-actions[bot]

Your changes do not pass checks.

tftpd

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Aug 11 '25 10:08 github-actions[bot]

/verify

Trevrosa avatar Aug 11 '25 10:08 Trevrosa

All changes look good.

Wait for review from human collaborators.

tftpd

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Aug 11 '25 10:08 github-actions[bot]

Ok, but PJO2/tftpd64#26 should be resolved first, I guess: https://www.virustotal.com/gui/url/fd065da44efbe5a318f13c88b39740d7538c68966ad1f52e113fa8c1c19bbcc0

aliesbelik avatar Aug 11 '25 20:08 aliesbelik

Currently https://www.virustotal.com/gui/file/c702d13b532b8619b7f057709aa4780f940830bae5affb68f2f859e8a7dbf91c listed 2/66 security vendors flagged this file as malicious. so I guess it should be fine?

Lutra-Fs avatar Aug 12 '25 04:08 Lutra-Fs

Here's an update:

  • v4.74
    • 64bit: 0/66 https://www.virustotal.com/gui/file/3ad38a71c0d7d42915429f8f02945e27bcf88161ad1028980d1364af8f76bf22
    • 32bit: 8/66 https://www.virustotal.com/gui/file/3e14c3830af443339bd0d90de9272d2b55662ec53e8479d4b54cbfb94e05a51e

z-Fng avatar Sep 25 '25 21:09 z-Fng

Currently https://www.virustotal.com/gui/file/c702d13b532b8619b7f057709aa4780f940830bae5affb68f2f859e8a7dbf91c listed 2/66 security vendors flagged this file as malicious. so I guess it should be fine?

0/66 https://www.virustotal.com/gui/file/3ad38a71c0d7d42915429f8f02945e27bcf88161ad1028980d1364af8f76bf22

ustsv avatar Oct 26 '25 14:10 ustsv

https://github.com/PJO2/tftpd64/issues/26 has been stalled for several months.

Here's an update:

  • v4.74

    • 64bit: 0/66 https://www.virustotal.com/gui/file/3ad38a71c0d7d42915429f8f02945e27bcf88161ad1028980d1364af8f76bf22
    • 32bit: 8/66 https://www.virustotal.com/gui/file/3e14c3830af443339bd0d90de9272d2b55662ec53e8479d4b54cbfb94e05a51e

Given the current situation, should we merge this?

z-Fng avatar Dec 06 '25 19:12 z-Fng

Walkthrough

The tftpd package manifest is updated from version 4.64 to 4.74, with license changed to GPL-2.0-only. Download URLs and hashes are migrated from Bitbucket to GitHub releases for both 32-bit and 64-bit architectures. The checkver and autoupdate configurations are updated accordingly to reference GitHub.

Changes

Cohort / File(s) Summary
Package manifest update
bucket/tftpd.json
Version bumped to 4.74; license updated to GPL-2.0-only; 64-bit and 32-bit download URLs and hashes migrated from Bitbucket to GitHub releases; checkver changed to GitHub-based object; autoupdate URLs pointed to GitHub releases with version substitution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the new version number matches the upstream release
  • Confirm hash values are correct for the new GitHub release URLs
  • Ensure the checkver GitHub pattern will correctly detect future versions
  • Validate that autoupdate substitution patterns are syntactically correct

Poem

🐰 From Bitbucket's distant shore to GitHub's gleaming gate,
tftpd makes its grand debut at version 4.74.
New licenses, fresh hashes, URLs all recastβ€”
The manifest evolves, and downloads flow at last! πŸ“¦βœ¨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is missing the closing issue link (mentions #15449 but description references v4.71 while summary shows v4.74 update) and lacks conventional PR title format mentioned in template. Clarify the actual target version (4.71 vs 4.74 discrepancy) and ensure the PR description includes explicit issue closure link in the specified format.
βœ… Passed checks (4 passed)
Check name Status Explanation
Title check βœ… Passed The title accurately summarizes the main changes: version update to 4.74 and fixes to checkver and autoupdate configuration.
Linked Issues check βœ… Passed The PR addresses issue #15449 by switching from broken Bitbucket download URLs to GitHub releases, directly resolving the root cause of installation failures.
Out of Scope Changes check βœ… Passed All changes are in-scope: version update, license change per repository requirements, URL migration to GitHub, and checkver/autoupdate fixes directly support resolving the broken installation issue.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
πŸ§ͺ Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 19 '25 20:12 coderabbitai[bot]