Extras icon indicating copy to clipboard operation
Extras copied to clipboard

[Bug]: UltraVNC config not persistent

Open user-mb opened this issue 1 year ago • 0 comments

Prerequisites

  • [X] I have written a descriptive issue title.
  • [X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • [X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

ultravnc.json

Expected/Current Behaviour

I am experiencing a loss of the configuration for UltraVNC upon either update or reinstall. It seems like the associated config file "UltraVNC.ini" which is by default created in the same folder as the executable, is not persistent.

I would appreciate it a lot if somebody with more experience with writing app manifests could include this.

Steps to Reproduce

scoop uninstall ultravnc
scoop install ultravnc

OR

scoop update ultravnc

Possible Solution

Including some lines to save and fetch config file UltraVNC.ini

I am personally unsure about how to write the pull properly, I would have stayed close to what other App manifests do. e.g.:

  "pre_install": [
       "if (!(Test-Path \"$persist_dir\\UltraVNC.ini\") -or !(Get-Item \"$persist_dir\\UltraVNC.ini\").Length) {",
       "   New-Item \"$persist_dir\\UltraVNC.ini\" -ItemType File -Force | Out-Null",
       "",
       "   if ($importConf -and (Test-Path $importConf)) {",
       "       Copy-Item $importConf \"$persist_dir\\UltraVNC.ini\"",
       "       Write-Host \"Imported existing UltraVNC.ini from $importConf.\" -ForegroundColor Yellow",
       "   }",
       "}"
   "uninstaller": {
       "script": "if ((Test-Path \"$dir\\UltraVNC.ini\") -and !(Get-Item \"$dir\\UltraVNC.ini\").LinkType -and (Test-Path $persist_dir)) { Copy-Item \"$dir\\UltraVNC.ini\" $persist_dir }",
   "persist": "UltraVNC.ini,

Scoop and Buckets Version

Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
434a0fbbf (HEAD -> master, origin/master, origin/HEAD) traefik: Update to version 3.1.6

'extras' bucket:
ee454f3c6 (HEAD -> master, origin/master, origin/HEAD) tomcat: Update to version 10.1.31

'versions' bucket:
7ab8ed60c (HEAD -> master, origin/master, origin/HEAD) swift-nightly: Update to version 20241009.2

'sysinternals' bucket:
6b2b695 (HEAD -> main, origin/main, origin/HEAD) sysmon: Update to version 15.15

'java' bucket:
f391914b (HEAD -> master, origin/master, origin/HEAD) temurin8-nightly-jre: Update to version 8.0.432-5.0.202410081519

Scoop Config

last_update         scoop_branch scoop_repo
-----------         ------------ ----------
09.10.2024 21:33:35 master       https://github.com/ScoopInstaller/Scoop

PowerShell Version

last_update         scoop_branch scoop_repo
-----------         ------------ ----------
09.10.2024 21:33:35 master       https://github.com/ScoopInstaller/Scoop

PS C:\Users\Artemis> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.4.5
PSEdition                      Core
GitCommitId                    7.4.5
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0&}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

user-mb avatar Oct 10 '24 07:10 user-mb