Extras icon indicating copy to clipboard operation
Extras copied to clipboard

GPT4All: Add version v3.4.1

Open guillermodotn opened this issue 1 year ago • 6 comments
trafficstars

Adding manifest for installation of GPT4All.

Closes #11531

guillermodotn avatar Sep 25 '24 06:09 guillermodotn

Your changes do not pass checks.

gpt4all

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Sep 25 '24 06:09 github-actions[bot]

/verify manifest checkver

guillermodotn avatar Sep 25 '24 07:09 guillermodotn

All changes look good.

Wait for review from human collaborators.

gpt4all

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Sep 25 '24 07:09 github-actions[bot]

  • Guess bin/shortcuts fields could be added as well.
  • Please update to the latest version.

aliesbelik avatar Sep 28 '24 09:09 aliesbelik

The installer automatically creates the shortcut, so including the shortcut property would create two of them, which I find unnecessary. I have added the following section to the manifest explaining why the shortcut property isn't included:

"##": [
        [
            "Shortcut section omitted as it is automatically created by the installer.",
            "bin/bin/chat.exe",
            "GPT4All"
        ]
    ],

guillermodotn avatar Sep 29 '24 11:09 guillermodotn

The comment explaining why the shortcut section was omitted has been modified as follows to resolve the workflow syntax checker issue (comments can not contain arrays).

"##": "Shortcut section omitted as it is automatically created by the installer.",

guillermodotn avatar Oct 12 '24 10:10 guillermodotn

@aliesbelik, could you please take a look at this?

guillermodotn avatar Mar 22 '25 20:03 guillermodotn