Extras icon indicating copy to clipboard operation
Extras copied to clipboard

[email protected]: Fix cleanup command deletes all Floorp data and version

Open SegoCode opened this issue 1 year ago • 8 comments

Closes #12958

SegoCode avatar Jun 26 '24 10:06 SegoCode

All changes look good.

Wait for review from human collaborators.

floorp

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Jun 26 '24 10:06 github-actions[bot]

/verify

SegoCode avatar Jun 26 '24 10:06 SegoCode

Your changes do not pass checks.

floorp

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [ ] Autoupdate

github-actions[bot] avatar Jun 26 '24 10:06 github-actions[bot]

/verify

SegoCode avatar Jun 26 '24 11:06 SegoCode

Your changes do not pass checks.

floorp

  • [x] Description
  • [x] License
  • [x] Hashes
  • [ ] Checkver
  • [ ] Autoupdate

github-actions[bot] avatar Jun 26 '24 11:06 github-actions[bot]

/verify

SegoCode avatar Jun 26 '24 11:06 SegoCode

All changes look good.

Wait for review from human collaborators.

floorp

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar Jun 26 '24 11:06 github-actions[bot]

Tested on a fresh windows install

imagen

Works as intended, cant reproduce the bug, profile 'scoop' now created successfully. Autoupdate also tested works fine. Using the same manifest for all firefox forks will help maintainability.

SegoCode avatar Jun 26 '24 15:06 SegoCode

It makes me quite sad that scoop buckets repos are so inactive, I delete my fork and leave the pr open in case someone wants to resume my proposal

SegoCode avatar Sep 27 '24 19:09 SegoCode