Extras icon indicating copy to clipboard operation
Extras copied to clipboard

KakaoTalkAdBlock: Add version 2.1.4

Open oxjihun opened this issue 1 year ago • 10 comments

Adds KakaoTalkAdBlock (2.0.0) to the bucket.

Closes #12883

oxjihun avatar Mar 18 '24 08:03 oxjihun

All changes look good.

Wait for review from human collaborators.

kakaotalkadblock

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver

github-actions[bot] avatar Mar 18 '24 08:03 github-actions[bot]

/verify

oxjihun avatar Mar 18 '24 08:03 oxjihun

All changes look good.

Wait for review from human collaborators.

kakaotalkadblock

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver

github-actions[bot] avatar Mar 18 '24 08:03 github-actions[bot]

@oxjihun Please add autoupdate section and 32bit version as well.

aliesbelik avatar Mar 30 '24 03:03 aliesbelik

/verify

oxjihun avatar May 30 '24 04:05 oxjihun

All changes look good.

Wait for review from human collaborators.

kakaotalkadblock

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar May 30 '24 04:05 github-actions[bot]

/verify

aliesbelik avatar May 31 '24 03:05 aliesbelik

All changes look good.

Wait for review from human collaborators.

kakaotalkadblock

  • [x] Description
  • [x] License
  • [x] Hashes
  • [x] Checkver
  • [x] Autoupdate

github-actions[bot] avatar May 31 '24 03:05 github-actions[bot]

Virustotal reports a lot of problems: https://www.virustotal.com/gui/file/951e277d65ac26c15437c24f0cd40983690321c104c491791035a420d62f8623

Even if false positive (blurfx/KakaoTalkAdBlock#83, blurfx/KakaoTalkAdBlock#85), guess this could cause problems on installation via scoop, when antivirus blocks installation or quarantines downloaded binaries in case of threat detection.

aliesbelik avatar May 31 '24 03:05 aliesbelik

@aliesbelik I apologize for making a pull request for a possibly malicious app.

To get things straight, I'd have to admit that I was partially aware of this. When writing the manifest for version 2.0.0, Windows Defender's inhibition was the main reason I couldn't include the 32bit version. There was no problem with 64bit version though. Since the program was regionally well known (at least I thought so), I regarded the 64bit version as safe. Never considered of running VirusTotal.

And yesterday, when writing the manifest for version 2.1.4, Windows Defender didn't raise any issues for downloading both 32bit and 64bit versions. I vaguely assumed that the false positive got fixed. Therefore, I proceeded to make a second commit.

Now I come to think of it, for transparency, I must have elaborated any issues upon opening the pull request. As this is my first time contributing to a large project on GitHub, I am still learning how to contribute 'well'. Though I know this is a mere excuse. I deeply apologize for all this inconvenience.

According to https://github.com/blurfx/KakaoTalkAdBlock/issues/85#issuecomment-2076390482, the dev managed to get the 2.1.4 version binaries removed from the malware detection list. With this, is there any chance that this manifest could be added to the Extras bucket?

Thank you.

oxjihun avatar May 31 '24 05:05 oxjihun