purepng icon indicating copy to clipboard operation
purepng copied to clipboard

Appveyor wheels

Open dougthor42 opened this issue 7 years ago • 5 comments

This is a redo of #25 based on the comments therein.

Fixes #24.

I've added Py24 and the others back. I've also made it so wheels are only built on on two versions of Python (this will speed up appveyor build times). All that's left is to modify the wheel script to upload to PyPI.

Please consider merging this, as the wheels make windows installs significantly easier.

dougthor42 avatar Aug 31 '17 01:08 dougthor42

Coverage Status

Coverage remained the same at 83.682% when pulling eb9631227181152a6fd88b96c2f7c79a22d70a6d on dougthor42:appveyor-wheels into ea9d5933b5dc2be95c5504a6ca973fd8084452b2 on Scondo:master.

coveralls avatar Aug 31 '17 01:08 coveralls

As I wrote before source-only wheels are not good as it disable speedup even on systems with C compiler.

You should add installation of Cython to provide truly binary wheels. I could do it myself later, but I need time for understand 'detect binary' and priority mechanism of building and installing wheels.

Until then pip install purepng provide pure-python mode for Windows (or even binary depending on compilator availability).

Scondo avatar Aug 31 '17 05:08 Scondo

Alright, I've added Cython to the build steps and changed things so that all versions >= 2.7 build true binary wheels for windows. I'm not going to worry about wheels for anything earlier than 2.7 since those have long been EoL'd.

Does that solve your concerns?

dougthor42 avatar Aug 31 '17 20:08 dougthor42

Coverage Status

Coverage remained the same at 83.682% when pulling eeafde4334d89b45f61e2835c5b85d4e656533a8 on dougthor42:appveyor-wheels into ea9d5933b5dc2be95c5504a6ca973fd8084452b2 on Scondo:master.

coveralls avatar Aug 31 '17 20:08 coveralls

OK. I'm not sure if I'll apply this for 0.2.1 but I definitely use this for 0.3.

I'll try to return to this project and release 0.3.0 as soon as possible. Nothing inspires like good pull request - thank you!

Scondo avatar Sep 01 '17 05:09 Scondo