quantumalgorithms.org icon indicating copy to clipboard operation
quantumalgorithms.org copied to clipboard

Add explaination on how to do the polynomial approximation of 1/x

Open github-actions[bot] opened this issue 3 years ago • 7 comments

Add explanation on how to do the polynomial approximation of 1/x This work offers theorem 17, 18, 19, which could be written with more explanation and steps..

https://arxiv.org/abs/1511.02306

Why not expanding these proofs so that more people can learn from them, and put them in the appendix of quantumalgorithms.org?

github-actions[bot] avatar Apr 07 '21 11:04 github-actions[bot]

Hi @Scinawa. You meant Lemmas 17-19, right? Can I work on that if nobody is currently preparing any PR for that? If yes, where exactly in the appendix should I put it?

Regards

gdeleva avatar Jun 19 '22 13:06 gdeleva

Hello @gdeleva ! Yes, I mean precisely those. These lemmas are quite technical to me, and would be nice to rewrite the proofs in an extended way, so to make the proof useful to people that wants to come up with similar tricks for other functions. Part of the work should be also to see how this polynomial can be used inside the singular value transformation framework.

The right place would be a new section in the appendix, called "Polynomial approximation of useful functions" (which I think it is commented and empty right now).

If you want we can discuss this via discord, I am happy to assign this issue to you if you want.

Ale

Scinawa avatar Jun 19 '22 16:06 Scinawa

@Scinawa Thanks. Sure, feel free to assign it to me. I will try to submit a PR in the next few days. If recommended, I will create an account in discord as well.

gdeleva avatar Jun 20 '22 07:06 gdeleva

Thanks! Let's talk in a few days, when you are free!

Scinawa avatar Jun 20 '22 08:06 Scinawa

@Scinawa Sure. Let me know how I can reach out to you. I am ready to submit a PR, but I guess I would first need to have specific access rights for it.

gdeleva avatar Jun 23 '22 02:06 gdeleva

You can contact me on discord, on the unitary.fund server, or the slack channel of the quantum open source foundation. You can send me an email to [email protected] so I can send you an invite. In general, you don't need an authorization for a PR. You just need to fork a repository, push your local changes to your github repository, and then open a pull request. :) I can help you with that!

Scinawa avatar Jun 23 '22 05:06 Scinawa

@Scinawa Thanks. I submitted a PR and sent an email. Looking forward to your feedback.

gdeleva avatar Jun 23 '22 06:06 gdeleva