parsec-cloud icon indicating copy to clipboard operation
parsec-cloud copied to clipboard

Pre-commit hooks to be run on all stages

Open mmmarcos opened this issue 1 year ago • 1 comments

Pre-commit hooks eslint and prettier are configured on manual. Unless there's a particular reason for that, they should probably be run on all stages.

Same for cspell, it's in manual and it often crashes on the CI. --> Update: Apparently running cspell it's quite slow, maybe run it only on push (not on commit?)

https://pre-commit.com/#confining-hooks-to-run-at-certain-stages

mmmarcos avatar Mar 18 '24 08:03 mmmarcos

Also, the snapcraft.yaml validation should be removed since that file no longer exists: https://github.com/Scille/parsec-cloud/blob/1826fedb2a33b886150bf2a0016ddf517d343f6f/.pre-commit-config.yaml#L314-L322

mmmarcos avatar Mar 20 '24 13:03 mmmarcos