DoctrineJsonFunctions icon indicating copy to clipboard operation
DoctrineJsonFunctions copied to clipboard

feat: add support for dbal v4

Open simPod opened this issue 1 year ago • 6 comments

simPod avatar Feb 04 '24 14:02 simPod

I think this will require too much work to get is working on unsupported php versions. I'm willing to implement this is we drop <8.2 php support.

simPod avatar Feb 04 '24 14:02 simPod

Great suggestion! This needs a major version upgrade, removing older unsupported php versions. Creating a 5.x branch and requiring php: ^8.1 support looks to me like the way forward.

Hikariii avatar Feb 05 '24 09:02 Hikariii

I think this will require too much work to get is working on unsupported php versions. I'm willing to implement this is we drop <8.2 php support.

Dropping php 8.1 is too much for me, since php 8.1 is still supported by Doctrine 3 and dbal 4

Hikariii avatar Feb 05 '24 11:02 Hikariii

Ok let me see what can be done.

simPod avatar Feb 07 '24 22:02 simPod

Tests were the worst. CI is green, WDYT?

simPod avatar Feb 07 '24 23:02 simPod

When to expect the new release?

abozhinov avatar Feb 29 '24 14:02 abozhinov

When to expect the new release?

Release 5.5.0 supports orm 3

Hikariii avatar Mar 08 '24 09:03 Hikariii

Tests were the worst. CI is green, WDYT?

Looks good, let me see if I can adopt and fix your work after a 5.x compatibility merge

Hikariii avatar Mar 08 '24 09:03 Hikariii

Closed because this is merged via https://github.com/ScientaNL/DoctrineJsonFunctions/pull/109

Hikariii avatar Mar 08 '24 12:03 Hikariii

I'm not as a contributor in release notes at dbal 4 support 🤔 🙃 🫠

simPod avatar Mar 08 '24 13:03 simPod

I'm quite sure you are: https://github.com/ScientaNL/DoctrineJsonFunctions/pull/109/commits/b153ee24af6d1e9b75bb2654e7eeb1ea72969162 It is a shared commit.

Hikariii avatar Mar 11 '24 09:03 Hikariii

Release notes image

simPod avatar Mar 11 '24 09:03 simPod