tephi icon indicating copy to clipboard operation
tephi copied to clipboard

move tephi to src/tephi

Open ESadek-MO opened this issue 1 year ago • 3 comments

part of #164

ESadek-MO avatar Nov 04 '24 11:11 ESadek-MO

Do we know why repo review advises the code to be under src? A quick check of the big four scientific python packages show three of them (numpy, pandas, scipy) have their package at the top of the repo like tephi currently does. matplotlib has its C and C++ code under src but its python code under lib.

rcomer avatar Nov 04 '24 16:11 rcomer

It's not repo review that's asking for this, so much as following Iris' conventions as far as I know! Repo review wants tests to be in root, but the rest of it is just standardising. If this proves too difficult, I don't mind putting this on the backburner.

ESadek-MO avatar Nov 05 '24 09:11 ESadek-MO

@rcomer See https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/ for some pros and cons

Personally I prefer the src-layout, but that's just me 😉

bjlittle avatar Nov 05 '24 09:11 bjlittle

In order to maintain a backlog of relevant PRs, we automatically label them as stale after 168 days of inactivity. If this PR is still important to you, then please comment on this PR and the stale label will be removed. Otherwise this PR will be automatically closed in 28 days time.

github-actions[bot] avatar Sep 25 '25 00:09 github-actions[bot]

This stale PR has been automatically closed due to a lack of community activity.

If you still care about this PR, then please either:

  • Re-open this PR, if you have sufficient permissions, or
  • Add a comment pinging @SciTools/tephi-maintainers who will re-open on your behalf.

github-actions[bot] avatar Oct 23 '25 00:10 github-actions[bot]