python-stratify icon indicating copy to clipboard operation
python-stratify copied to clipboard

Stratify option to use float32

Open abooton opened this issue 5 years ago • 4 comments

Model precision means that model data often only needs to be of type float32 or int32 data. However, vertical stratify is currently converting data to float64 for its calculations. This is unnecessary for some usecases and too slow for some operational use cases.

AC:

  • Update stratify to accept and maintain data as float32.

See benfitzpatrick for more details.

abooton avatar Nov 07 '19 08:11 abooton

@abooton Thanks 👍

bjlittle avatar Nov 07 '19 08:11 bjlittle

I tried converting to cython: floating (https://github.com/SciTools-incubator/python-stratify/compare/master...benfitzpatrick:float_32_preservation) but it didn't/doesn't work with the inheritance structure (fused type support + inheritance problem).

benfitzpatrick avatar Nov 27 '19 10:11 benfitzpatrick

@SciTools/peloton reviewing this : leaving it open, but it won't happen for quite a while. @benfitzpatrick is this still of interest ?

pp-mo avatar Mar 29 '23 09:03 pp-mo

Still of interest, I reckon, but @s-boardman and @PaulAbernethy now better points of contact!

In general I think the Scientific Python community needs to make much more use of float32 wherever possible - faster, less memory, don't need the bits

benfitzpatrick avatar Mar 29 '23 14:03 benfitzpatrick

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

github-actions[bot] avatar Aug 11 '24 00:08 github-actions[bot]

This stale issue has been automatically closed due to a lack of community activity.

If you still care about this issue, then please either:

  • Re-open this issue, if you have sufficient permissions, or
  • Add a comment pinging @SciTools/stratify-maintainers who will re-open on your behalf.

github-actions[bot] avatar Sep 08 '24 00:09 github-actions[bot]