iris
iris copied to clipboard
SciTools
Reinstate CubeList._repr_html_()
🚀 Pull Request
To address #4973
NOTE: aiming this at a bugfix release, so it is derived from, and targetting '3.3.x' branch.
TODO:
- [x] add whatsnew
- ( create appropriate new whatsnew/latest.rst, on v3.3.x aiming for 3.3.1 )
Pure tests to start with -- proving that the test for Cubelist._repr_html_() will fail.
Ok, naming @trexfeathers and @lbdreyer as possible reviewers. @lbdreyer simply because I'm still easing into Pytest usage.
We need to consider the implications for this going in a 3.3.1 release. TODO: (for me) work out what a whatsnew "latest.rst" should look like in this case + initiate it.
Regarding
TODO: (for me) work out what a whatsnew "latest.rst" should look like in this case + initiate it.
Rather than editing latest.rst. I think you just need to edit the 3.3.rst to add a section for bug fixes (as we did in https://github.com/SciTools/iris/pull/4604/files) and then add your whats new entry to this?
Regarding
TODO: (for me) work out what a whatsnew "latest.rst" should look like in this case + initiate it.
Rather than editing latest.rst. I think you just need to edit the 3.3.rst to add a section for bug fixes (as we did in https://github.com/SciTools/iris/pull/4604/files) and then add your whats new entry to this?
Ok thanks, that makes sense ! I tried to consult the developer docs, but it isn't really clear about this IMHO
Thanks @lbdreyer Hope I have fixed those things now.
N.B. I am just about to check actual notebook output, but I tidied my conda + it is taking ages to build a test env ... Best to wait for that.
Ok I think this will work now : Fixed the glitch in the whatsnew. I also checked that it does work as expected in a notebook :heavy_check_mark:
Whoops, Looks like there was a problem with the docs build from this merge: https://readthedocs.org/projects/scitools-iris/builds/18152663/
Whoops, Looks like there was a problem with the docs build from this merge: https://readthedocs.org/projects/scitools-iris/builds/18152663/
Some kind of HDF error, could be a bit of a random glitch ? Just trying a re-build : https://readthedocs.org/projects/scitools-iris/builds/18168111/
Ok it has built, but my new whatsnew is not properly contained in the dropdown section Need more indent. However, I think we should shortly be adding to this section in #4933, so I will fix it there ...