iris-grib icon indicating copy to clipboard operation
iris-grib copied to clipboard

iris-grib prettier

Open HGWright opened this issue 1 year ago • 2 comments

https://learn.scientific-python.org/development/guides/repo-review/?repo=scitools%2Firis-grib

HGWright avatar Mar 20 '24 15:03 HGWright

@HGWright prettier uses node to do it's formatting, but unfortunately the glibc version on the VDI is too old i.e.,

> ldd --version
ldd (GNU libc) 2.17
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.

And prettier seems to need 2.25+

So you might want to skip repo-review compliance with this i.e., instead add the following to the pyproject.toml,

[tool.repo-review]
ignore = [
    # https://learn.scientific-python.org/development/guides/style/#PC180
    "PC180",  # Uses prettier.
]

bjlittle avatar Apr 04 '24 13:04 bjlittle