cartopy icon indicating copy to clipboard operation
cartopy copied to clipboard

MNT: Switch to (lon, lat) for all argument and return ordering

Open greglucas opened this issue 1 year ago • 1 comments

There are more usages of (lon, lat) currently and only a few private versions of (lat, lon) so it is easy enough to switch everything over to (lon, lat) for consistency. This matches what we are expecting from transform_point(x, y) as well.

greglucas avatar Oct 11 '24 20:10 greglucas

Curious what the failure cause is?

Looks like an issue with a corrupted shapefile download or something that Fiona is causing errors from which leads to a later error.

type = <class 'weakref.KeyedRef'>, ob = None
callback = <function WeakValueDictionary.__init__.<locals>.remove at 0x000001D0FE0E63E0>
key = <cartopy.mpl.feature_artist._GeomKey object at 0x000001D0FFA4D590>

    def __new__(type, ob, callback, key):
>       self = ref.__new__(type, ob, callback)
E       TypeError: cannot create weak reference to 'NoneType' object

C:\hostedtoolcache\windows\Python\3.11.9\x64\Lib\weakref.py:348: TypeError
------------------------------ Captured log call ------------------------------
ERROR    fiona._env:shapereader.py:217 Error in fread() reading object of size 248 at offset 332 from .shp file
ERROR    fiona._env:shapereader.py:217 Error in fread() reading object of size 1128 at offset 580 from .shp file
ERROR    fiona._env:shapereader.py:217 Error in fread() reading object of size 792 at offset [170](https://github.com/SciTools/cartopy/actions/runs/11298952884/job/31428955719?pr=2453#step:9:171)8 from .shp file
ERROR    fiona._env:shapereader.py:217 fread(27) failed on DBF file.

I reran the job as this seems like something intermittent and unrelated.

greglucas avatar Oct 16 '24 03:10 greglucas