SciTools
Added winkel tripel projection class
Rationale
Winkel-Tripel is a popular projection that would be used by multiple users (my group at UT and folks at NCAR). It is also the primary projection for the National Geographic Society.
Implications
I have created a new CRS projection object without modifying any code by utilizing existing class objects and the pyproj backend.
Checklist
- The new class object can be utilized in similar fashion to the other projection classes.
- I am unsure how to integrate this into the existing test suite, however I imagine it would undergo the same testing as other projections. I am happy to assist with that integration if I could be pointed in the right direction.
This is my first pull request! I am open to input how on to properly contribute.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.
:x: AgentOxygen
:x: greglucas
You have signed the CLA already but the status is still pending? Let us recheck it.
ping @AgentOxygen did you want to try and get this in still? It looks like it needs tests and a possible update to the keyword argument.
Apologies for the delay, I just finished up my master's thesis! I've added the test and an image for comparison. I noticed several of the tests failed, though I'm not sure how to proceed. What are the next steps I should take to get this integrated.
Apologies for the delay, I just finished up my master's thesis!
🎉 Congratulations, @AgentOxygen!
@AgentOxygen, it looks like the image comparison is failing now. I pushed the formatting fix, but otherwise this looks good to go to me once you can update the images to the expected content.