cartopy icon indicating copy to clipboard operation
cartopy copied to clipboard

ENH: Allow Natural Earth version to be specified

Open lgolston opened this issue 11 months ago • 4 comments

Rationale

As requested in #2293, it would be useful for reproducibility to be able to specify what Natural Earth version to use, in addition to current default behavior of downloading the latest version.

Implications

This enhancement is added. If a version is specified, it will be downloaded to subfolders within cultural or physical corresponding to the version requested and then used.

Checklist

Testing: Since Natural Earth is already in several places in the test suite, I modified one of them to now use a specific version.

lgolston avatar Mar 15 '24 02:03 lgolston

Do we also need something to expose the version option on NaturalEarthFeature, similar to how scale is handled?

rcomer avatar Mar 15 '24 08:03 rcomer

Do we also need something to expose the version option on NaturalEarthFeature, similar to how scale is handled?

Yes, thanks. Version should definitely be an option there too but I wasn't tracking that feature - have added it in now.

lgolston avatar Mar 16 '24 02:03 lgolston

Related, I have linked there to https://github.com/nvkelso/natural-earth-vector/releases as a good source for version information, because it was confusing that most of the versions shown on https://www.naturalearthdata.com/ (e.g. 4.0.0, 2.0.0, etc.) are not available on the AWS service to download, yet there are many newer versioned releases that are available which are not shown on https://www.naturalearthdata.com/.

lgolston avatar Mar 16 '24 02:03 lgolston

CI helped pick up an omission of version in one place in NaturalEarthFeature - a clean version is now pushed with that edit.

lgolston avatar Mar 17 '24 02:03 lgolston