Utilise Scaler class in GSHHSFeature

[kaedonkers]

Rationale

Utilise Scaler object in GSHHSFeature like it is used in NaturalEarthFeature.

Implications

Code more readable and scale_from_extent now abstracted out to Scaler class.

[kaedonkers]

After more testing it seems I've broken GSHHSFeature. I'll dig a bit more...

[QuLogic]

Any progress here?

[kaedonkers]

I will not get a chance to fix this in time for the v0.17 release so will push it back to v0.18.

[greglucas]

@kaedonkers, any update on trying to get this in for the v0.18 release?

[kaedonkers]

@greglucas Realistically, I probably won't get around to finishing this in time for the release. Go ahead with the release and if I get it in before you release then happy days.

[kaedonkers]

I re-ran the CI and there are failures all over regarding pip. Is this a known issue or have I messed up?

[greglucas]

I think you may have been unlucky, I don't see any changes you've made that would have caused any issues with installation.

[kaedonkers]

Thanks for looking. I've rebased the changes, let's see if that helps.

[kaedonkers]

Thanks for looking. I've rebased the changes, let's see if that helps.

[greglucas]

Uh oh! It looks like something went wrong in the rebase because you're bringing in a ton of commits and conflicts now. Try and give it another shot?

[QuLogic]

Tagging the rc today, so I'm pushing this back to 0.19.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 13 committers have signed the CLA.

:white_check_mark: greglucas
:white_check_mark: pelson
:x: QuLogic
:x: ajdawson
:x: ocefpaf
:x: shevawen
:x: dopplershift
:x: htonchia
:x: zbruick
:x: pharshalp
:x: kacmak7
:x: kaedonkers
:x: Mark Wieczorek

---

Mark Wieczorek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}