SciSharp.Models icon indicating copy to clipboard operation
SciSharp.Models copied to clipboard

Hardcoded path in KerasLayer.cs

Open dharmeshtailor opened this issue 2 years ago • 1 comments

In this file, the module path is hardcoded to "C:\Users\haipi\AppData\Local\Temp\tfhub_modules\602d30248ff7929470db09f7385fc895e9ceb4c0"

SciSharp.Models.Core/TensorflowHub/KerasLayer.cs https://github.com/SciSharp/SciSharp.Models/blob/master/SciSharp.Models.Core/TensorflowHub/KerasLayer.cs

I cannot use it because of this. Although the work around is to create that directory structure.

dharmeshtailor avatar Nov 14 '23 23:11 dharmeshtailor

There is other hardcoded things, for example in the file SciSharp.Models.TimeSeries/BaselineModel.cs the column name for the WeatherPrediction example shows up. var baseline = new Baseline(_window.GetColumnIndex("T (degC)"));

I think there should be a ReadMe added to this repo so people know that it's meant to be used as example, and not referenced directly in projects.

zacuke avatar Oct 19 '24 05:10 zacuke