CodeMinion icon indicating copy to clipboard operation
CodeMinion copied to clipboard

np class is not static in np.module.gen.cs

Open epignatelli opened this issue 6 years ago • 4 comments

Is it a special case, or is it just lapse?

epignatelli avatar Jul 30 '19 09:07 epignatelli

it should be static, this is a bug

henon avatar Jul 30 '19 09:07 henon

Thanks @henon.

I am going through the code since I am trying to port some of the projects in your stack to a visual programming interface. I might find this small stuff, I am keen to push a fix here and there (I do it locally anyway). What's your usual workflow for contributing?

epignatelli avatar Jul 30 '19 09:07 epignatelli

Any help is appreciated. If you fix bugs or improve anything please send a PR, we'll review and merge all acceptable changes.

Be sure not to make manual changes in generated files! Instead the generator has to be fixed (this is one of those cases). When changing the generator generate the code for Numpy.NET and Torch.NET and check the changes in the generated code (i.e. by looking over the git diff) to see that nothing broke. When you check in changes in the generator, please also check in the changes it has on the generated code of the projects Numpy.NET and Torch.NET.

henon avatar Jul 30 '19 11:07 henon

Thanks @henon for the guidance, I'll ring a pr in a while.

epignatelli avatar Jul 30 '19 15:07 epignatelli