sciruby-notebooks icon indicating copy to clipboard operation
sciruby-notebooks copied to clipboard

Formula language notebook requires updation

Open lokeshh opened this issue 9 years ago • 15 comments

"AgeuponOutcome(Weeks)" causes an error because with brackets the column name become invalid. Need to update dataframe column name. Its easy to fix. Just noting this issue down so I don't forget it.

lokeshh avatar Sep 07 '16 20:09 lokeshh

Hi @lokeshh, I would like to fix this but would need some guidance, if you can help. Thanks.

snpd25 avatar Jan 20 '19 12:01 snpd25

Good. You can get started by setting up iRuby notebook. If you face any problem let me know.

lokeshh avatar Jan 20 '19 13:01 lokeshh

I have done the setup of Ruby kernel in Jupyter Notebook. What's next to be done?

snpd25 avatar Jan 20 '19 20:01 snpd25

Could you verify if notebooks in sciruby-notebooks/Data Analysis/Categorical Data/examples are working as expected?

lokeshh avatar Jan 21 '19 05:01 lokeshh

Yup, they are working fine.

snpd25 avatar Jan 21 '19 17:01 snpd25

Now rename the column AgeuponOutcome(Weeks) to AgeuponOutcome or something else which does use parenthesis.

lokeshh avatar Jan 22 '19 06:01 lokeshh

I once changed AgeuponOutcome(Weeks) to AgeuponOutcome and then to Ageupon(Outcome) . In both the cases it worked the same as it was working before.

snpd25 avatar Jan 22 '19 08:01 snpd25

@snpd25 Could you try with latest code from statsample-glm master branch and see if it still works? To install a gem from git repository you can use this https://github.com/rdp/specific_install

lokeshh avatar Jan 22 '19 09:01 lokeshh

I feel that I am not doing exactly what is required, I installed the statsample-glm gem and then checked the example [Example] Formula language in Statsample-GLM.ipynb with the same changes, and it was working the same as before. Am I missing something?

snpd25 avatar Jan 22 '19 16:01 snpd25

Ok let me take a look and get back to you

On Tue 22 Jan, 2019, 10:23 PM snpd25 <[email protected] wrote:

I feel that I am not doing exactly what is required, I installed the statsample-glm gem and then checked the example [Example] Formula language in Statsample-GLM.ipynb with the same changes, and it was working the same as before. Am I missing something?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SciRuby/sciruby-notebooks/issues/28#issuecomment-456474681, or mute the thread https://github.com/notifications/unsubscribe-auth/AHUmVI28JKvHxU-iT55yYgB0H391PEOMks5vF0ISgaJpZM4J3TEJ .

lokeshh avatar Jan 23 '19 07:01 lokeshh

@snp25 I ran the latest code of statsample-glm against latest code of daru and getting the error as expected. Maybe you should remove all versions of daru and statsample-glm and then install their latest versions from git.

lokeshh avatar Jan 24 '19 11:01 lokeshh

screenshot from 2019-01-26 14-28-57 See if I am doing as required.

snpd25 avatar Jan 26 '19 09:01 snpd25

Firstly you should get an error in cell 17 (without making any changes in notebook) to verify that you are using the latest daru and statsample. By latest I don't mean latest release but the latest gem from repository master branch.

Once you have done that, then you should try to fix that error. The error can be fixed by simply renaming the column name and reflecting that name in cell 17.

lokeshh avatar Jan 26 '19 09:01 lokeshh

screenshot from 2019-01-26 17-11-26 I tried modifying the file example [Example] Formula language in Statsample-GLM.ipynb. It's showing the same result.

snpd25 avatar Jan 26 '19 11:01 snpd25

@lokeshh I have re-installed everything and started afresh but there is some problem with using statsample-glm in the notebook. It says:

NameError: uninitialized constant Statsample::GLM::Regression
Did you mean?  Statsample::Regression

snpd25 avatar Feb 07 '19 01:02 snpd25