daru-view icon indicating copy to clipboard operation
daru-view copied to clipboard

[DataTables]: Need to change require path

Open Shekharrajak opened this issue 7 years ago • 3 comments

If issue: https://github.com/Shekharrajak/daru-data_tables/issues/24 is done , then related changes has to be done in daru-view/datatables

Shekharrajak avatar Aug 23 '18 09:08 Shekharrajak

Note : Has to finish before new release : https://github.com/SciRuby/daru-view/pull/123

Shekharrajak avatar Aug 29 '18 17:08 Shekharrajak

I guess this is done?

v0dro avatar Dec 06 '18 14:12 v0dro

@v0dro , actually code point of view it is done in https://github.com/Shekharrajak/daru-data_tables/pull/22 and https://github.com/SciRuby/daru-view/pull/114, but we still have old folder structure https://github.com/Shekharrajak/daru-data_tables/pull/22#issuecomment-414583306 ; if we rearrange the folder structure in daru-data_tables then we need to change the path in daru-view as well. refer : https://github.com/SciRuby/daru-view/pull/114#pullrequestreview-148815322

Shekharrajak avatar Dec 06 '18 15:12 Shekharrajak