kmath icon indicating copy to clipboard operation
kmath copied to clipboard

Mathematical correctness of terms

Open altavir opened this issue 3 years ago • 7 comments

As mentioned by @dievsky, the current names of Algebras are not quite consistent with mathematical definitions. For example, NDField is not actually a field since not all elements are invertable (a structure with a single zero is not). This fact should be shown in the documentation. There could be also limited renaming in class names if there are clear candidates.

altavir avatar Jan 20 '21 06:01 altavir

Actually, there had been already some violations of structures' properties: e.g., + in MstRing is not commutative.

CommanderTvis avatar Jan 20 '21 07:01 CommanderTvis

Indeed, those things should be mentioned in documentation as well.

altavir avatar Jan 20 '21 08:01 altavir

  1. I made a mistake when called XOperations semiX in the doc comments.
  2. I still propose introducing a separate class for Group.

CommanderTvis avatar Jan 21 '21 16:01 CommanderTvis

I do not want to complicate APIuselessly, so some use-cases are in order. Could you create a separate use case issue for them?

altavir avatar Jan 21 '21 16:01 altavir

Boolean algebra gives a ring where a + b = (a /\ -b) \/ (-x /\ y) and a * b = a /\ b

CommanderTvis avatar Jan 21 '21 16:01 CommanderTvis

And multiplying boolean by scalar makes no sense of course.

CommanderTvis avatar Jan 21 '21 16:01 CommanderTvis

As I already said, boolean algebra should be derived directly from Algebra and not inherit any intermediate steps.

altavir avatar Jan 21 '21 16:01 altavir