getting-started icon indicating copy to clipboard operation
getting-started copied to clipboard

Ci broken

Open pietroppeter opened this issue 3 years ago • 4 comments
trafficstars

after merging #47 the CI broke: https://github.com/SciNim/getting-started/actions/runs/3136348556/jobs/5093144122 It seems there was some error when running basics/data_wrangling.nim so a log should have been created but it is not found (maybe it failed too fast). this is a bit complicated due to async processing added to nimibook in https://github.com/pietroppeter/nimibook/pull/53, not sure if @beef331 can help here. I am currently thinking we might want to have an option in nimibook to disable the async processing in nimibook for better troubleshooting these cases.

pietroppeter avatar Sep 27 '22 14:09 pietroppeter

at the moment I would not know what to look for. one option would be to temporarily revert the async build in nimibook.

pietroppeter avatar Sep 27 '22 14:09 pietroppeter

It seems there was some error when running basics/data_wrangling.nim so a log should have been created but it is not found (maybe it failed too fast).

If you expect a file that is created on the result of an async proc you should have a Future[T] variable you can await no ?

Clonkk avatar Sep 27 '22 15:09 Clonkk

here is the file and proc where the async build is done (and above in buildNim you can see where the log file is created): https://github.com/pietroppeter/nimibook/blob/main/src/nimibook/builds.nim#L49

I am very weak on async so I cannot really tell if there is a bug or not.

on the matter of why CI is breaking, looking at #50 (which has no async build) it seems there is some issue with datamancer possibly related to an updated version.

pietroppeter avatar Sep 27 '22 16:09 pietroppeter

It seems there was some error when running basics/data_wrangling.nim so a log should have been created but it is not found (maybe it failed too fast)

mmh, no, since the error is called in this line it seems that after the error when running basics/data_wrangling.nim it is not actually able to open the log file to write the log. Maybe at that point the folder it was supposed to be in changed and the path is no longer valid? it should probably use an absolute path and not a relative one...

pietroppeter avatar Sep 27 '22 16:09 pietroppeter