diffeqpy icon indicating copy to clipboard operation
diffeqpy copied to clipboard

Automate the Julia installation

Open ChrisRackauckas opened this issue 3 years ago • 3 comments

@johnnychen94 is this the right way to check for an existing installation?

@tkf can you help make sure this works correctly with diffeqpy?

ChrisRackauckas avatar Jan 01 '21 15:01 ChrisRackauckas

Looks good to me. I guess you'll also need to add jill as the dependency in https://github.com/SciML/diffeqpy/blob/28cf12434393a9c30fa8c78f55e0a8fd4e56996a/setup.py#L27

johnnychen94 avatar Jan 01 '21 16:01 johnnychen94

I'm not a Python expert so I don't know where the reference is but it seems that the codes(installation) run only when you do import diffeqpy.de and not on import diffeqpy. To make it work, we have to do it in diffeqpy/__init__.py.

Given that jill.py doesn't support quite installation now, probably a better place is to put it in install() and let users trigger it manually?

johnnychen94 avatar Jan 01 '21 20:01 johnnychen94

@tkf set that part up so I'll have to ask for his guidance there.

ChrisRackauckas avatar Jan 01 '21 23:01 ChrisRackauckas

This automation is now done by JuliaCall

ChrisRackauckas avatar Oct 10 '23 21:10 ChrisRackauckas