SymbolicNumericIntegration.jl icon indicating copy to clipboard operation
SymbolicNumericIntegration.jl copied to clipboard

Add support for definite integration

Open GregVernon opened this issue 1 year ago • 3 comments

See this Discourse conversation: https://discourse.julialang.org/t/integrating-symbolic-functions/102545

Thought I'd start a basic MR with the most naive implementation, and let it evolve from here. I've only done the most basic manual testing (e.g. integrate $x$ over the domain [0,1]), but am open to suggestions for how to build out testing -- is it enough to rely on Symbolics.substitute unit tests, and then just a few return-type / edge case tests?

GregVernon avatar Aug 08 '23 03:08 GregVernon

is it enough to rely on Symbolics.substitute unit tests, and then just a few return-type / edge case tests?

It would be good to test a few values and cases.

ChrisRackauckas avatar Aug 08 '23 15:08 ChrisRackauckas

Codecov Report

Merging #59 (ca1a14b) into main (ae77a3d) will decrease coverage by 64.87%. The diff coverage is 0.00%.

:exclamation: Current head ca1a14b differs from pull request most recent head 9aaa42e. Consider uploading reports for the commit 9aaa42e to get more accurate results

@@            Coverage Diff             @@
##             main     #59       +/-   ##
==========================================
- Coverage   64.96%   0.10%   -64.87%     
==========================================
  Files          14      14               
  Lines         942     933        -9     
==========================================
- Hits          612       1      -611     
- Misses        330     932      +602     
Files Changed Coverage Δ
src/integral.jl 0.00% <0.00%> (-80.51%) :arrow_down:

... and 10 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 08 '23 15:08 codecov[bot]

I think this can be closed as superseded by https://github.com/SciML/SymbolicNumericIntegration.jl/pull/63 ?

knuesel avatar Mar 08 '24 16:03 knuesel