StochasticDiffEq.jl icon indicating copy to clipboard operation
StochasticDiffEq.jl copied to clipboard

Dynamical integrators

Open HadrienNU opened this issue 1 year ago • 8 comments

Following discussion in #259 this is a proposed implementation of the ABOBA and OBABO integrators (GJ set of integrators coming later). I have also modified the BAOAB implementation to allow matrix as friction (the gamma parameter) in the equation.

That seems to work, but I am not sure to have done everything properly (in particular to verify is gamma is a matrix or not). So let me know if there are changes to do.

Also, I would like to add the integrator to the documentation, but I am not sure of where I should propose changes.

HadrienNU avatar Sep 11 '23 17:09 HadrienNU

I think the implementation looks reasonable. @frankschae could you take a look through it as well?

ChrisRackauckas avatar Sep 17 '23 21:09 ChrisRackauckas

I have added some correction to OBABO that actually require 2 noise processes.

HadrienNU avatar Sep 18 '23 13:09 HadrienNU

I think the implementation looks pretty good to go? @frankschae what do you think should be done with the problem types here?

ChrisRackauckas avatar Oct 16 '23 08:10 ChrisRackauckas

I just realized I forgot about these. Let's see what's going on with those convergence tests and get this merged.

ChrisRackauckas avatar Nov 17 '23 11:11 ChrisRackauckas

I change the convergence tests (and separate also the tests into convergence and interface tests).

I did not update the c1 and c2 as function as @frankschae requested yet, waiting the reply to my comment

HadrienNU avatar Nov 20 '23 11:11 HadrienNU

Unexpected Pass
 Expression: abs(sim1.𝒪est[:weak_final] - 2) < 0.5
 Got correct result, please change to @test if no longer broken.

:-D

frankschae avatar Nov 20 '23 15:11 frankschae

By the way, did you know a way to reduce the frequency of the log output?

[ Info: Monte Carlo iteration: 90088/100000

The logs start to be very heavy when reaching 100000 iterations

HadrienNU avatar Nov 20 '23 15:11 HadrienNU

No but I think a PR would be very welcome. You could add a verbose kwarg to

https://github.com/SciML/DiffEqDevTools.jl/blob/5a4439f33ddcc5c1ca561cad125f77e01015af72/src/convergence.jl#L121

frankschae avatar Nov 20 '23 15:11 frankschae