SciMLSensitivity.jl icon indicating copy to clipboard operation
SciMLSensitivity.jl copied to clipboard

add tests for Enzyme frontend for nonlinear problem

Open m-bossart opened this issue 1 year ago • 5 comments

Add tests for SciML/NonlinearSolve.jl#439

m-bossart avatar Jun 09 '24 15:06 m-bossart

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.23%. Comparing base (8dd3bdf) to head (e9d8786).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1066       +/-   ##
===========================================
- Coverage   60.03%   37.23%   -22.80%     
===========================================
  Files          19       19               
  Lines        4586     4496       -90     
===========================================
- Hits         2753     1674     -1079     
- Misses       1833     2822      +989     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 10 '24 17:06 codecov[bot]

Where is this at?

ChrisRackauckas avatar Jun 28 '24 01:06 ChrisRackauckas

I made the change to not use a closure put pass all the arguments to autodiff. I included the tests for all the cases that we included previously with Zygote but not all of them pass (the commented ones). The uncommented tests with Enzyme should pass

m-bossart avatar Jun 28 '24 22:06 m-bossart

I mean, what needs to review and merge first?

ChrisRackauckas avatar Jun 29 '24 02:06 ChrisRackauckas

First SciML/SimpleNonlinearSolve.jl#151, then this should be ready.

m-bossart avatar Jun 29 '24 19:06 m-bossart