SciMLOperators.jl icon indicating copy to clipboard operation
SciMLOperators.jl copied to clipboard

[WIP] 3 arg update_func

Open vpuri3 opened this issue 1 year ago • 2 comments

fix https://github.com/SciML/SciMLOperators.jl/issues/202

Operators should accept a single update_func with two methods A = update_func(u, p, t), and update_func(A, u, p, t) # = nothing. The DEFAULT_UPDATE_FUNC shall return nothing to indicate that no update has taken place.

TO DO

  • [ ] remove update_func!
  • [ ] add 3 arg DEFAULT_UPDATE_FUNC
  • [ ] bump version to 0.4

vpuri3 avatar Jun 18 '23 18:06 vpuri3

Codecov Report

Merging #206 (b63bfb2) into master (3e808d1) will decrease coverage by 1.24%. Report is 3 commits behind head on master. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   70.08%   68.84%   -1.24%     
==========================================
  Files          10       10              
  Lines        1588     1589       +1     
==========================================
- Hits         1113     1094      -19     
- Misses        475      495      +20     
Files Coverage Δ
src/matrix.jl 63.91% <ø> (-4.13%) :arrow_down:
src/interface.jl 40.36% <0.00%> (-6.86%) :arrow_down:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jun 18 '23 18:06 codecov[bot]

Hey, what's the status of this? It could be good to merge soon-ish to minimize the amount of code in the old style we'll have to adjust

gaurav-arya avatar Aug 12 '23 20:08 gaurav-arya