SciMLBenchmarks.jl icon indicating copy to clipboard operation
SciMLBenchmarks.jl copied to clipboard

PINN solver benchmarks are broken

Open killah-t-cell opened this issue 2 years ago • 3 comments

Parts of the PINN solver benchmarks are not compiling

Screenshot 2021-11-30 at 10 49 59

https://benchmarks.sciml.ai/html/PINNErrorsVsTime/allen_cahn_et.html

killah-t-cell avatar Nov 30 '21 09:11 killah-t-cell

Yes, I pinged @KirillZubov and @francescocalisto on fixing it, though if anyone wants to get to it first be my guest because I don't plan to get to it any time soon. I was just trying to get the benchmarks like 90% setup so that others can then help 😅

ChrisRackauckas avatar Nov 30 '21 09:11 ChrisRackauckas

look like just outdated code after update and it is just need add couple new parameter to build_loss_function.

KirillZubov avatar Nov 30 '21 10:11 KirillZubov

https://github.com/SciML/SciMLBenchmarks.jl/pull/355

I fixed allen_cahn. Not sure about the results of the prediction.

@francescocalisto could you please check how much iteration is needed and etc.

Also, other scripts in PINNErrorsVsTime need to update because there also use low-level API which was changed, and code outdate. https://github.com/SciML/SciMLBenchmarks.jl/tree/master/benchmarks/PINNErrorsVsTime

KirillZubov avatar Nov 30 '21 15:11 KirillZubov

This is fixed.

ChrisRackauckas avatar Sep 27 '22 07:09 ChrisRackauckas