SciMLBenchmarks.jl icon indicating copy to clipboard operation
SciMLBenchmarks.jl copied to clipboard

Fix NBodySimulator Benchmarks

Open ChrisRackauckas opened this issue 3 years ago • 6 comments

Continuouing https://github.com/SciML/SciMLBenchmarks.jl/pull/245 here.

@SebastianM-C these time out. How long do they take?

ChrisRackauckas avatar May 15 '21 11:05 ChrisRackauckas

It is possible to be over an hour, but I'm not sure, I'll have to run them and see. Should I try to make it shorter? What should be the benchmark duration?

SebastianM-C avatar May 15 '21 11:05 SebastianM-C

They are failing at 6 hours.

ChrisRackauckas avatar May 15 '21 11:05 ChrisRackauckas

Oh... That's unexpected.

SebastianM-C avatar May 15 '21 11:05 SebastianM-C

Are there any logs available to see where it hangs / what happens?

SebastianM-C avatar May 15 '21 11:05 SebastianM-C

https://buildkite.com/julialang/scimlbenchmarks-dot-jl/builds/242#df9f5bc4-7f12-416e-8583-7e8e6088387b

ChrisRackauckas avatar May 15 '21 11:05 ChrisRackauckas

I ran them locally and it looks like it's not getting stuck, but that the benchmarks take very long image

I'll try to have a look at some concrete examples to see if there are any performance regressions, but it may also be due to how many runs we have at different tolerances.

SebastianM-C avatar Jun 09 '21 15:06 SebastianM-C