fix: propagate kwargs to remake_initialization_data

Open vyudu opened this issue 9 months ago • 2 comments

Mar 31 '25 21:03 vyudu

Right yeah I change the MTK function here https://github.com/SciML/ModelingToolkit.jl/pull/3516

On Tue, Apr 1, 2025 at 12:35 AM Aayush Sabharwal @.***> wrote:

@.**** requested changes on this pull request.

This is breaking. The method in MTK doesn't have kwargs, so this will never dispatch to it.

— Reply to this email directly, view it on GitHub https://github.com/SciML/SciMLBase.jl/pull/978#pullrequestreview-2731087945, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANAOXYEANYIXJUZYNNSE7KL2XIJRDAVCNFSM6AAAAAB2FKUPUGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMZRGA4DOOJUGU . You are receiving this because you authored the thread.Message ID: @.***>

Apr 01 '25 05:04 vyudu

It's still breaking, because this version of SciMLBase won't work with older versions of MTK

Apr 01 '25 05:04 AayushSabharwal