SciMLBase.jl icon indicating copy to clipboard operation
SciMLBase.jl copied to clipboard

Add iscomplex type param to PDESolutions

Open xtalax opened this issue 2 years ago • 3 comments

xtalax avatar Jan 09 '23 15:01 xtalax

What is this? And won't other constructors need to be updated for this?

ChrisRackauckas avatar Jan 09 '23 15:01 ChrisRackauckas

Codecov Report

Merging #361 (71487a2) into master (0235a49) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   57.46%   57.45%   -0.01%     
==========================================
  Files          43       43              
  Lines        3289     3291       +2     
==========================================
+ Hits         1890     1891       +1     
- Misses       1399     1400       +1     
Impacted Files Coverage Δ
src/solutions/pde_solutions.jl 0.00% <0.00%> (ø)
src/retcodes.jl 31.57% <0.00%> (-3.51%) :arrow_down:
src/integrator_interface.jl 45.51% <0.00%> (-1.67%) :arrow_down:
src/interpolation.jl 32.95% <0.00%> (-0.39%) :arrow_down:
src/solutions/solution_interface.jl 59.25% <0.00%> (ø)
src/ensemble/ensemble_analysis.jl 79.50% <0.00%> (+0.81%) :arrow_up:
src/ensemble/basic_ensemble_solve.jl 81.73% <0.00%> (+0.96%) :arrow_up:
src/solutions/ode_solutions.jl 93.93% <0.00%> (+2.02%) :arrow_up:
src/operators/common_defaults.jl 67.64% <0.00%> (+2.94%) :arrow_up:
src/tabletraits.jl 73.33% <0.00%> (+10.00%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jan 09 '23 16:01 codecov[bot]

Just something to dispatch on for when the solution is complex, though on second thought I could do this with the metadata.

Is anyone else using these yet?

xtalax avatar Jan 17 '23 11:01 xtalax